]> www.infradead.org Git - users/jedix/linux-maple.git/commit
EDAC: i7core, sb_edac: Don't return NOTIFY_BAD from mce_decoder callback
authorTony Luck <tony.luck@intel.com>
Fri, 29 Apr 2016 13:42:25 +0000 (15:42 +0200)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:21:51 +0000 (17:21 -0500)
commit782fe6e05d652f59a7ea4a989aab17e1b7ff45db
treefcfbaf1aa4059c4bb138b50ee5b88788fc917eb3
parent5d7eb724cc5ccac0fe33d296e8877ad5b7b860d3
EDAC: i7core, sb_edac: Don't return NOTIFY_BAD from mce_decoder callback

Orabug: 25227145

[ Upstream commit c4fc1956fa31003bfbe4f597e359d751568e2954 ]

Both of these drivers can return NOTIFY_BAD, but this terminates
processing other callbacks that were registered later on the chain.
Since the driver did nothing to log the error it seems wrong to prevent
other interested parties from seeing it. E.g. neither of them had even
bothered to check the type of the error to see if it was a memory error
before the return NOTIFY_BAD.

Signed-off-by: Tony Luck <tony.luck@intel.com>
Acked-by: Aristeu Rozanski <aris@redhat.com>
Acked-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/72937355dd92318d2630979666063f8a2853495b.1461864507.git.tony.luck@intel.com
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit cb4a26d103973231b1a4f6b4c1495f41aaeb9980)

Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/edac/i7core_edac.c
drivers/edac/sb_edac.c