]> www.infradead.org Git - users/willy/pagecache.git/commit
i2c: core: Allocate temporary client dynamically
authorGeert Uytterhoeven <geert+renesas@glider.be>
Thu, 20 Feb 2025 15:12:12 +0000 (16:12 +0100)
committerWolfram Sang <wsa+renesas@sang-engineering.com>
Sat, 22 Feb 2025 09:27:37 +0000 (10:27 +0100)
commit781813db7909d945c33d3b035822225f3598774d
treeaa0b175aec5918000c5d78cd7fdad1a52a7df418
parent0ad2507d5d93f39619fc42372c347d6006b64319
i2c: core: Allocate temporary client dynamically

drivers/i2c/i2c-core-base.c: In function ‘i2c_detect.isra’:
drivers/i2c/i2c-core-base.c:2544:1: warning: the frame size of 1312 bytes is larger than 1024 bytes [-Wframe-larger-than=]
 2544 | }
      | ^

Fix this by allocating the temporary client structure dynamically, as it
is a rather large structure (1216 bytes, depending on kernel config).
This is basically a revert of the to-be-fixed commit with some
checkpatch improvements.

Fixes: 735668f8e5c9 ("i2c: core: Allocate temp client on the stack in i2c_detect")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Su Hui <suhui@nfschina.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
[wsa: updated commit message, merged tags from similar patch]
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
drivers/i2c/i2c-core-base.c