]> www.infradead.org Git - users/jedix/linux-maple.git/commit
scsi: megaraid_sas: add correct return type check for ldio hint logic for raid1
authorShivasharan S <shivasharan.srikanteshwara@broadcom.com>
Fri, 10 Mar 2017 11:22:13 +0000 (03:22 -0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 1 Jun 2017 21:06:13 +0000 (14:06 -0700)
commit77c0f8012337fc3187e815badf675605326107f0
tree0d7ec7d0fce7420a456df0c02747f02f72df6b45
parent29081da4ff84387332e2b444644b0c99632ece00
scsi: megaraid_sas: add correct return type check for ldio hint logic for raid1

Orabug: 26096381

Return value check of atomic_dec_if_positive is required as it returns
old value minus one.  Without this fix, driver will send small ios to
firmware path and that will be a performance issue.

Not critical, but good to have r1_ldio_hint as default value in sdev
private.

Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Shivasharan S <shivasharan.srikanteshwara@broadcom.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
(cherry picked from commit 49524b3c6e12375627ddd870613fcc6b24909898)
Signed-off-by: Somasundaram Krishnasamy <somasundaram.krishnasamy@oracle.com>
Signed-off-by: Kirtikar Kashyap <kirtikar.kashyap@oracle.com>
Reviewed-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/scsi/megaraid/megaraid_sas_base.c
drivers/scsi/megaraid/megaraid_sas_fusion.c