]> www.infradead.org Git - users/jedix/linux-maple.git/commit
tracing: Replace multiple deprecated strncpy with memcpy
authorJustin Stitt <justinstitt@google.com>
Mon, 14 Oct 2024 21:13:14 +0000 (14:13 -0700)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 30 Oct 2024 23:41:08 +0000 (19:41 -0400)
commit77a1326f64c3245ae9d2f9297abec5c8a0f11f58
treee6261c56467b2d66965ccee8a33573b13b75b526
parent2c33155ef678033b8a3105b824cdef930f05b47d
tracing: Replace multiple deprecated strncpy with memcpy

strncpy() is deprecated for use on NUL-terminated destination strings [1] and
as such we should prefer more robust and less ambiguous string interfaces.

String copy operations involving manual pointer offset and length
calculations followed by explicit NUL-byte assignments are best changed
to either strscpy or memcpy.

strscpy is not a drop-in replacement as @len would need a one subtracted
from it to avoid truncating the source string.

To not sabotage readability of the current code, use memcpy (retaining
the manual NUL assignment) as this unambiguously describes the desired
behavior.

Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings
Link: https://github.com/KSPP/linux/issues/90
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: linux-hardening@vger.kernel.org
Link: https://lore.kernel.org/20241014-strncpy-kernel-trace-trace_events_filter-c-v2-1-d821e81e371e@google.com
Reviewed-by: Kees Cook <kees@kernel.org>
Signed-off-by: Justin Stitt <justinstitt@google.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events_filter.c