]> www.infradead.org Git - users/jedix/linux-maple.git/commit
pinctrl: qcom/lpi: Convert to platform remove callback returning void
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 9 Oct 2023 16:25:08 +0000 (18:25 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 10 Oct 2023 13:47:49 +0000 (15:47 +0200)
commit776d54c137a38f99701fa5cc65d947244dda1b78
treeab8082623d03bde016fd31e3e6f0ed83d6c7fd1c
parent93650550dff9d1a3b88c553f8adb81dc89778977
pinctrl: qcom/lpi: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

To convert all those qcom pinctrl drivers, make msm_pinctrl_remove()
return void (instead of zero) and use .remove_new in all drivers.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20231009162510.335208-2-u.kleine-koenig@pengutronix.de
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/qcom/pinctrl-lpass-lpi.c
drivers/pinctrl/qcom/pinctrl-lpass-lpi.h
drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
drivers/pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c
drivers/pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c
drivers/pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c
drivers/pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c
drivers/pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c
drivers/pinctrl/qcom/pinctrl-sm8550-lpass-lpi.c