]> www.infradead.org Git - users/dwmw2/linux.git/commit
vhost: correctly remove wait queue during poll failure
authorJason Wang <jasowang@redhat.com>
Tue, 27 Mar 2018 12:50:52 +0000 (20:50 +0800)
committerSasha Levin <alexander.levin@microsoft.com>
Wed, 23 May 2018 01:36:30 +0000 (21:36 -0400)
commit76c575ab119f717c135be4242ca1223e2fc21d7f
tree64c49d412d432e49be492262267d22858ef82122
parent8bd47807a2ab033ba9a67f28de559e6dc005e00e
vhost: correctly remove wait queue during poll failure

[ Upstream commit dc6455a71c7fc5117977e197f67f71b49f27baba ]

We tried to remove vq poll from wait queue, but do not check whether
or not it was in a list before. This will lead double free. Fixing
this by switching to use vhost_poll_stop() which zeros poll->wqh after
removing poll from waitqueue to make sure it won't be freed twice.

Cc: Darren Kenny <darren.kenny@oracle.com>
Reported-by: syzbot+c0272972b01b872e604a@syzkaller.appspotmail.com
Fixes: 2b8b328b61c79 ("vhost_net: handle polling errors when setting backend")
Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Darren Kenny <darren.kenny@oracle.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
drivers/vhost/vhost.c