]> www.infradead.org Git - users/dwmw2/linux.git/commit
mfd: tps65219: Remove TPS65219_REG_TI_DEV_ID check
authorShree Ramamoorthy <s-ramamoorthy@ti.com>
Thu, 6 Feb 2025 17:37:23 +0000 (11:37 -0600)
committerLee Jones <lee@kernel.org>
Fri, 14 Mar 2025 08:59:06 +0000 (08:59 +0000)
commit76b58d5111fdcffce615beb71520bc7a6f1742c9
tree7bbfbf25a0997b75ca33908274a9fdc6b18f1920
parent5a004cf474ae957026d47608959ca399571b0865
mfd: tps65219: Remove TPS65219_REG_TI_DEV_ID check

The chipid macro/variable and regmap_read function call is not needed
because the TPS65219_REG_TI_DEV_ID register value is not a consistent value
across TPS65219 PMIC config versions. Reading from the DEV_ID register
without a consistent value to compare it to isn't useful. There isn't a
way to verify the match data ID is the same ID read from the DEV_ID device
register. 0xF0 isn't a DEV_ID value consistent across TPS65219 NVM
configurations.

For TPS65215, there is a consistent value in bits 5-0 of the DEV_ID
register. However, there are other error checks in place within probe()
that apply to both PMICs rather than keeping this isolated check for one
PMIC.

Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com>
Link: https://lore.kernel.org/r/20250206173725.386720-4-s-ramamoorthy@ti.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/tps65219.c