]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fuse: clear PG_uptodate when using a stolen page
authorMiklos Szeredi <mszeredi@redhat.com>
Wed, 28 Aug 2024 13:55:17 +0000 (15:55 +0200)
committerMiklos Szeredi <mszeredi@redhat.com>
Wed, 28 Aug 2024 16:10:29 +0000 (18:10 +0200)
commit76a51ac00ca2a72fe3e168b7fb0e70f75ba6f512
tree6c032a85fcb95bcc21c7861d04683880c98d9453
parent3002240d16494d798add0575e8ba1f284258ab34
fuse: clear PG_uptodate when using a stolen page

Originally when a stolen page was inserted into fuse's page cache by
fuse_try_move_page(), it would be marked uptodate.  Then
fuse_readpages_end() would call SetPageUptodate() again on the already
uptodate page.

Commit 413e8f014c8b ("fuse: Convert fuse_readpages_end() to use
folio_end_read()") changed that by replacing the SetPageUptodate() +
unlock_page() combination with folio_end_read(), which does mostly the
same, except it sets the uptodate flag with an xor operation, which in the
above scenario resulted in the uptodate flag being cleared, which in turn
resulted in EIO being returned on the read.

Fix by clearing PG_uptodate instead of setting it in fuse_try_move_page(),
conforming to the expectation of folio_end_read().

Reported-by: Jürg Billeter <j@bitron.ch>
Debugged-by: Matthew Wilcox <willy@infradead.org>
Fixes: 413e8f014c8b ("fuse: Convert fuse_readpages_end() to use folio_end_read()")
Cc: <stable@vger.kernel.org> # v6.10
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/fuse/dev.c