]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: ov08x40: Don't log ov08x40_check_hwcfg() errors twice
authorHans de Goede <hdegoede@redhat.com>
Fri, 20 Dec 2024 14:41:30 +0000 (15:41 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Sat, 15 Feb 2025 14:22:40 +0000 (15:22 +0100)
commit766d952c08bddfa1a503322df6feb1396f6a7107
tree9bc19b0f993e2f60eb5ece46519075117192d519
parent4254dc1ab3b8d095cacb1e273b37d6e56bd980bd
media: ov08x40: Don't log ov08x40_check_hwcfg() errors twice

All ov08x40_check_hwcfg() error-exit paths already log a detailed reason,
logging a second generic "failed to check hwcfg" error is not useful, and
in case of the fwnode check failing with -EPROBE_DEFER this is outright
problematic flooding the log with:

[    4.557059] ov08x40 i2c-OVTI08F4:00: failed to check hwcfg: -517
[    4.559636] ov08x40 i2c-OVTI08F4:00: failed to check hwcfg: -517
etc.

messages.

The one exception to all ov08x40_check_hwcfg() error-exit paths already
logging an error is on v4l2_fwnode_endpoint_alloc_parse() errors.

Make ov08x40_check_hwcfg() log an error in that case too and drop
the duplicate "failed to check hwcfg: %d\n" error logging.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/i2c/ov08x40.c