]> www.infradead.org Git - linux.git/commit
btrfs: fix passing 0 to ERR_PTR in btrfs_search_dir_index_item()
authorYue Haibing <yuehaibing@huawei.com>
Tue, 22 Oct 2024 09:52:08 +0000 (17:52 +0800)
committerDavid Sterba <dsterba@suse.com>
Tue, 22 Oct 2024 14:10:55 +0000 (16:10 +0200)
commit75f49c3dc7b7423d3734f2e4dabe3dac8d064338
tree24ab82f1be70221420e126678af657f937d02b58
parent3c36a72c1d27de6618c1c480c793d9924640f5bb
btrfs: fix passing 0 to ERR_PTR in btrfs_search_dir_index_item()

The ret may be zero in btrfs_search_dir_index_item() and should not
passed to ERR_PTR(). Now btrfs_unlink_subvol() is the only caller to
this, reconstructed it to check ERR_PTR(-ENOENT) while ret >= 0.

This fixes smatch warnings:

fs/btrfs/dir-item.c:353
  btrfs_search_dir_index_item() warn: passing zero to 'ERR_PTR'

Fixes: 9dcbe16fccbb ("btrfs: use btrfs_for_each_slot in btrfs_search_dir_index_item")
CC: stable@vger.kernel.org # 6.1+
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/dir-item.c
fs/btrfs/inode.c