]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xen: correctly check for pending events when restoring irq flags
authorDavid Vrabel <david.vrabel@citrix.com>
Thu, 26 Apr 2012 18:44:06 +0000 (19:44 +0100)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Mon, 30 Apr 2012 15:14:57 +0000 (11:14 -0400)
commit75ca88bfa50a6b341fed1d7efe046d1a23723fc4
tree2eb47a0499f08ba143412ae3b7e6af9478821f4d
parent2ce98d504209fa7af3149ca7691c8a0b866c3495
xen: correctly check for pending events when restoring irq flags

In xen_restore_fl_direct(), xen_force_evtchn_callback() was being
called even if no events were pending.  This resulted in (depending on
workload) about a 100 times as many xen_version hypercalls as
necessary.

Fix this by correcting the sense of the conditional jump.

This seems to give a significant performance benefit for some
workloads.

There is some subtle tricksy "..since the check here is trying to
check both pending and masked in a single cmpw, but I think this is
correct. It will call check_events now only when the combined
mask+pending word is 0x0001 (aka unmasked, pending)." (Ian)

[upstream git commit 7eb7ce4d2e8991aff4ecb71a81949a907ca755ac]
CC: stable@kernel.org
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Signed-off-by: David Vrabel <david.vrabel@citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
arch/x86/xen/xen-asm.S