]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: ti: icssg-prueth: Fix kernel warning while bringing down network interface
authorMeghana Malladi <m-malladi@ti.com>
Tue, 15 Apr 2025 09:05:41 +0000 (14:35 +0530)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 17 Apr 2025 10:11:24 +0000 (12:11 +0200)
commit75bc744466444ef417b5f709f72b91c83301bcd1
tree0813b4b2225c8556ab6574aa54b84f75093551bd
parent4798cfa2097f0833d54d8f5ce20ef14631917839
net: ti: icssg-prueth: Fix kernel warning while bringing down network interface

During network interface initialization, the NIC driver needs to register
its Rx queue with the XDP, to ensure the incoming XDP buffer carries a
pointer reference to this info and is stored inside xdp_rxq_info.

While this struct isn't tied to XDP prog, if there are any changes in
Rx queue, the NIC driver needs to stop the Rx queue by unregistering
with XDP before purging and reallocating memory. Drop page_pool destroy
during Rx channel reset as this is already handled by XDP during
xdp_rxq_info_unreg (Rx queue unregister), failing to do will cause the
following warning:

warning logs: https://gist.github.com/MeghanaMalladiTI/eb627e5dc8de24e42d7d46572c13e576

Fixes: 46eeb90f03e0 ("net: ti: icssg-prueth: Use page_pool API for RX buffer allocation")
Signed-off-by: Meghana Malladi <m-malladi@ti.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Link: https://patch.msgid.link/20250415090543.717991-2-m-malladi@ti.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/ti/icssg/icssg_common.c