]> www.infradead.org Git - users/willy/xarray.git/commit
net: pse-pd: tps23881: Fix power on/off issue
authorKory Maincent <kory.maincent@bootlin.com>
Fri, 20 Dec 2024 17:04:00 +0000 (18:04 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 23 Dec 2024 18:40:34 +0000 (10:40 -0800)
commit75221e96101fa93390d3db5c23e026f5e3565d9b
tree08981a3ed6f5e29aec7b382f09a9bec5eef5c8c0
parent4a4d38ace1fb0586bffd2aab03caaa05d6011748
net: pse-pd: tps23881: Fix power on/off issue

An issue was present in the initial driver implementation. The driver
read the power status of all channels before toggling the bit of the
desired one. Using the power status register as a base value introduced
a problem, because only the bit corresponding to the concerned channel ID
should be set in the write-only power enable register. This led to cases
where disabling power for one channel also powered off other channels.

This patch removes the power status read and ensures the value is
limited to the bit matching the channel index of the PI.

Fixes: 20e6d190ffe1 ("net: pse-pd: Add TI TPS23881 PSE controller driver")
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>
Link: https://patch.msgid.link/20241220170400.291705-1-kory.maincent@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/pse-pd/tps23881.c