]> www.infradead.org Git - users/willy/pagecache.git/commit
ALSA: compress_offload: fix remaining descriptor races in sound/core/compress_offload.c
authorAl Viro <viro@zeniv.linux.org.uk>
Sun, 29 Dec 2024 18:52:32 +0000 (18:52 +0000)
committerTakashi Iwai <tiwai@suse.de>
Mon, 30 Dec 2024 10:49:38 +0000 (11:49 +0100)
commit7439b395211874e20c24b2fe0e4903864357a3f5
treef853ce6c302434e1b5c1275e1c116835fa88cd5e
parentac9fae799eda81e24bbf2e0d5cb9e5c33fc9bdcb
ALSA: compress_offload: fix remaining descriptor races in sound/core/compress_offload.c

3d3f43fab4cf ("ALSA: compress_offload: improve file descriptors
installation for dma-buf") fixed some of descriptor races in
snd_compr_task_new(), but there's a couple more left.

We need to grab the references to dmabuf before moving them into
descriptor table - trying to do that by descriptor afterwards might
end up getting a different object, with a dangling reference left in
task->{input,output}

Fixes: 3d3f43fab4cf ("ALSA: compress_offload: improve file descriptors installation for dma-buf")
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Link: https://patch.msgid.link/20241229185232.GA1977892@ZenIV
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/compress_offload.c