]> www.infradead.org Git - users/hch/misc.git/commit
mm/damon/core: initialize damos->walk_completed in damon_new_scheme()
authorSeongJae Park <sj@kernel.org>
Fri, 28 Feb 2025 17:44:50 +0000 (09:44 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Mar 2025 00:40:23 +0000 (17:40 -0700)
commit73d7a69de212aebb59f4ff23aae0422e86c488fe
treee7b05990c02c94deef4b521d419c45c18c435d22
parent39a326e6daba5703a8e4de17cacc7ddb0dc5b07f
mm/damon/core: initialize damos->walk_completed in damon_new_scheme()

The function for allocating and initialize a 'struct damos' object,
damon_new_scheme(), is not initializing damos->walk_completed field.  Only
damos_walk_complete() is setting the field.  Hence the field will be
eventually set and used correctly from second damos_walk() call for the
scheme.  But the first damos_walk() could mistakenly not walk on the
regions.  Actually, a common usage of DAMOS for taking an access pattern
snapshot is installing a monitoring-purpose DAMOS scheme, doing
damos_walk() to retrieve the snapshot, and then removing the scheme.
DAMON user-space tool (damo) also gets runtime snapshot in the way.  Hence
the problem can continuously happen in such use cases.  Initialize it
properly in the allocation function.

Link: https://lkml.kernel.org/r/20250228174450.41472-1-sj@kernel.org
Fixes: bf0eaba0ff9c ("mm/damon/core: implement damos_walk()")
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core.c