]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.
authorAlexandre Ferrieux <alexandre.ferrieux@gmail.com>
Sun, 10 Nov 2024 17:28:36 +0000 (18:28 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 13 Nov 2024 02:26:03 +0000 (18:26 -0800)
commit73af53d82076bbe184d9ece9e14b0dc8599e6055
tree24297073f910e35a18cd48019ed264fa1e34b6fd
parent2b99b2532593b5a4c7dc6bff2486e98d211a8596
net: sched: cls_u32: Fix u32's systematic failure to free IDR entries for hnodes.

To generate hnode handles (in gen_new_htid()), u32 uses IDR and
encodes the returned small integer into a structured 32-bit
word. Unfortunately, at disposal time, the needed decoding
is not done. As a result, idr_remove() fails, and the IDR
fills up. Since its size is 2048, the following script ends up
with "Filter already exists":

  tc filter add dev myve $FILTER1
  tc filter add dev myve $FILTER2
  for i in {1..2048}
  do
    echo $i
    tc filter del dev myve $FILTER2
    tc filter add dev myve $FILTER2
  done

This patch adds the missing decoding logic for handles that
deserve it.

Fixes: e7614370d6f0 ("net_sched: use idr to allocate u32 filter handles")
Reviewed-by: Eric Dumazet <edumazet@google.com>
Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Alexandre Ferrieux <alexandre.ferrieux@orange.com>
Tested-by: Victor Nogueira <victor@mojatatu.com>
Link: https://patch.msgid.link/20241110172836.331319-1-alexandre.ferrieux@orange.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/cls_u32.c