]> www.infradead.org Git - users/dwmw2/qemu.git/commit
qga: fix missing static and prototypes windows warnings
authorPierrick Bouvier <pierrick.bouvier@linaro.org>
Thu, 31 Oct 2024 04:04:20 +0000 (21:04 -0700)
committerKonstantin Kostiuk <kkostiuk@redhat.com>
Mon, 4 Nov 2024 12:16:14 +0000 (14:16 +0200)
commit73aaabcf22f9ba61721e5920b6c152bf71a7aed9
tree001a5f3ec0d7bd6068aeaaeb0863c7036a6b8077
parent24287d440bf90667e4da7d05eb431ec5c80e72ad
qga: fix missing static and prototypes windows warnings

Reported by clang++, but not by g++.

../qga/vss-win32/provider.cpp:48:6: error: no previous prototype for function 'LockModule' [-Werror,-Wmissing-prototypes]
   48 | void LockModule(BOOL lock)
      |      ^
../qga/vss-win32/provider.cpp:48:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   48 | void LockModule(BOOL lock)
      | ^
      | static
../qga/vss-win32/provider.cpp:531:13: error: no previous prototype for function 'DllMain' [-Werror,-Wmissing-prototypes]
  531 | BOOL WINAPI DllMain(HINSTANCE hinstDll, DWORD dwReason, LPVOID lpReserved)
      |             ^
../qga/vss-win32/provider.cpp:531:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
  531 | BOOL WINAPI DllMain(HINSTANCE hinstDll, DWORD dwReason, LPVOID lpReserved)
      | ^
      | static

Signed-off-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Konstantin Kostiuk <kkostiuk@redhat.com>
Link: https://lore.kernel.org/r/20241031040426.772604-7-pierrick.bouvier@linaro.org
Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
qga/vss-win32/install.cpp
qga/vss-win32/provider.cpp
qga/vss-win32/requester.cpp