]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: hid-input: Fix accessing freed memory during device disconnect
authorKrzysztof Kozlowski <k.kozlowski@samsung.com>
Mon, 3 Aug 2015 05:57:30 +0000 (14:57 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 13 Sep 2015 16:07:41 +0000 (09:07 -0700)
commit731fedc9a4c9192e0250e8615d2db08134749b3d
treeb836be889933bd2a7540e0b784d5e90ddaba2710
parent0d2808f59028f624b18529bc445a1dcdcec56ae9
HID: hid-input: Fix accessing freed memory during device disconnect

commit 0621809e37936e7c2b3eac9165cf2aad7f9189eb upstream.

During unbinding the driver was dereferencing a pointer to memory
already freed by power_supply_unregister().

Driver was freeing its internal description of battery through pointers
stored in power_supply structure. However, because the core owns the
power supply instance, after calling power_supply_unregister() this
memory is freed and the driver cannot access these members.

Fix this by storing the pointer to internal description of battery in a
local variable before calling power_supply_unregister(), so the pointer
remains valid.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reported-by: H.J. Lu <hjl.tools@gmail.com>
Fixes: 297d716f6260 ("power_supply: Change ownership from driver to core")
Reviewed-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/hid-input.c