]> www.infradead.org Git - users/jedix/linux-maple.git/commit
sunrpc/cache: drop reference when sunrpc_cache_pipe_upcall() detects a race
authorNeilBrown <neilb@suse.com>
Fri, 4 Mar 2016 06:20:13 +0000 (17:20 +1100)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:22:02 +0000 (17:22 -0500)
commit723143888e4b3a35e34821335d0d9707650aa09a
tree961c05275adae048cf958fd4c003768e04c459f5
parentf62582d5ecbbb08f8df953ed720b1dde768679e7
sunrpc/cache: drop reference when sunrpc_cache_pipe_upcall() detects a race

Orabug: 25308069

[ Upstream commit a6ab1e8126d205238defbb55d23661a3a5c6a0d8 ]

sunrpc_cache_pipe_upcall() can detect a race if CACHE_PENDING is no longer
set.  In this case it aborts the queuing of the upcall.
However it has already taken a new counted reference on "h" and
doesn't "put" it, even though it frees the data structure holding the reference.

So let's delay the "cache_get" until we know we need it.

Fixes: f9e1aedc6c79 ("sunrpc/cache: remove races with queuing an upcall.")
Signed-off-by: NeilBrown <neilb@suse.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit e28574abf31fbce4ae38606989b3f18e72838b97)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
net/sunrpc/cache.c