]> www.infradead.org Git - users/jedix/linux-maple.git/commit
x86/irq: Retrieve irq data after locking irq_desc
authorThomas Gleixner <tglx@linutronix.de>
Sun, 5 Jul 2015 17:12:35 +0000 (17:12 +0000)
committerEthan Zhao <ethan.zhao@oracle.com>
Wed, 23 Aug 2017 03:57:00 +0000 (12:57 +0900)
commit71d3239aa945532063d452b5fbb6d1a6fb068ba7
treef0823904f4053d250472365e82106d81d3b64a41
parent3accbe981a9fa4de96af39f6c03a0cc6dfdb922e
x86/irq: Retrieve irq data after locking irq_desc

irq_data is protected by irq_desc->lock, so retrieving the irq chip
from irq_data outside the lock is racy vs. an concurrent update. Move
it into the lock held region.

While at it add a comment why the vector walk does not require
vector_lock.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: xiao jin <jin.xiao@intel.com>
Cc: Joerg Roedel <jroedel@suse.de>
Cc: Borislav Petkov <bp@suse.de>
Cc: Yanmin Zhang <yanmin_zhang@linux.intel.com>
Link: http://lkml.kernel.org/r/20150705171102.331320612@linutronix.de
(cherry picked from commit 09cf92b784fae6109450c5d64f9908066d605249)

Orabug: 25671838

Signed-off-by: Ethan Zhao <ethan.zhao@oracle.com>
Reviewed-by: Jack Vogel <jack.vogel@oracle.com>
arch/x86/kernel/irq.c