]> www.infradead.org Git - users/hch/misc.git/commit
i2c: ls2x: Fix frequency division register access
authorBinbin Zhou <zhoubinbin@loongson.cn>
Thu, 20 Feb 2025 12:56:12 +0000 (20:56 +0800)
committerAndi Shyti <andi.shyti@kernel.org>
Wed, 26 Feb 2025 22:23:33 +0000 (23:23 +0100)
commit71c49ee9bb41e1709abac7e2eb05f9193222e580
tree005193c4e29be7957558d8c86dd6ab60e9c671e8
parentdd1998e243f5fa25d348a384ba0b6c84d980f2b2
i2c: ls2x: Fix frequency division register access

According to the chip manual, the I2C register access type of
Loongson-2K2000/LS7A is "B", so we can only access registers in byte
form (readb()/writeb()).

Although Loongson-2K0500/Loongson-2K1000 do not have similar
constraints, register accesses in byte form also behave correctly.

Also, in hardware, the frequency division registers are defined as two
separate registers (high 8-bit and low 8-bit), so we just access them
directly as bytes.

Fixes: 015e61f0bffd ("i2c: ls2x: Add driver for Loongson-2K/LS7A I2C controller")
Co-developed-by: Hongliang Wang <wanghongliang@loongson.cn>
Signed-off-by: Hongliang Wang <wanghongliang@loongson.cn>
Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: stable@vger.kernel.org # v6.3+
Reviewed-by: Andy Shevchenko <andy@kernel.org>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20250220125612.1910990-1-zhoubinbin@loongson.cn
drivers/i2c/busses/i2c-ls2x.c