]> www.infradead.org Git - users/jedix/linux-maple.git/commit
dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop
authorMarc Gonzalez <mgonzalez@freebox.fr>
Mon, 29 Apr 2024 14:04:51 +0000 (16:04 +0200)
committerKalle Valo <quic_kvalo@quicinc.com>
Mon, 13 May 2024 14:15:47 +0000 (17:15 +0300)
commit71b6e321e30271beb08772871c4f76777f49e402
tree6c975d24a88a18933d60c0b926e8134f1eb51526
parent3b9344740843d965e9e37fba30620b3b1c0afa4f
dt-bindings: net: wireless: ath10k: add qcom,no-msa-ready-indicator prop

The ath10k driver waits for an "MSA_READY" indicator
to complete initialization. If the indicator is not
received, then the device remains unusable.

cf. ath10k_qmi_driver_event_work()

Several msm8998-based devices are affected by this issue.
Oddly, it seems safe to NOT wait for the indicator, and
proceed immediately when QMI_EVENT_SERVER_ARRIVE.

Jeff Johnson wrote:

  The feedback I received was "it might be ok to change all ath10k qmi
  to skip waiting for msa_ready", and it was pointed out that ath11k
  (and ath12k) do not wait for it.

  However with so many deployed devices, "might be ok" isn't a strong
  argument for changing the default behavior.

Kalle Valo first suggested setting a bit in firmware-5.bin to trigger
work-around in the driver. However, firmware-5.bin is parsed too late.
So we are stuck with a DT property.

Signed-off-by: Marc Gonzalez <mgonzalez@freebox.fr>
Reviewed-by: Bjorn Andersson <quic_bjorande@quicinc.com>
Acked-by: Jeff Johnson <quic_jjohnson@quicinc.com>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://msgid.link/54ac2295-36b4-49fc-9583-a10db8d9d5d6@freebox.fr
Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml