]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ovl: fix regression caused by lookup helpers API changes
authorAmir Goldstein <amir73il@gmail.com>
Thu, 5 Jun 2025 10:15:30 +0000 (12:15 +0200)
committerChristian Brauner <brauner@kernel.org>
Thu, 5 Jun 2025 11:17:08 +0000 (13:17 +0200)
commit714d02b41939d2720379e11ef25227aec4e5bec9
treed4a08a0ff343313fe323c84087daa0cf6d6790c9
parentb55eb6eb2a7427428c59b293a0900131fc849595
ovl: fix regression caused by lookup helpers API changes

The lookup helpers API was changed by merge of vfs-6.16-rc1.async.dir to
pass a non-const qstr pointer argument to lookup_one*() helpers.

All of the callers of this API were changed to pass a pointer to temp
copy of qstr, except overlays that was passing a const pointer to
dentry->d_name that was changed to pass a non-const copy instead
when doing a lookup in lower layer which is not the fs of said dentry.

This wrong use of the API caused a regression in fstest overlay/012.

Fix the regression by making a non-const copy of dentry->d_name prior
to calling the lookup API, but the API should be fixed to not allow this
class of bugs.

Cc: NeilBrown <neilb@suse.de>
Fixes: 5741909697a3 ("VFS: improve interface for lookup_one functions")
Fixes: 390e34bc1490 ("VFS: change lookup_one_common and lookup_noperm_common to take a qstr")
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Link: https://lore.kernel.org/20250605101530.2336320-1-amir73il@gmail.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/overlayfs/namei.c