]> www.infradead.org Git - users/willy/pagecache.git/commit
tee: optee: Fix supplicant wait loop
authorSumit Garg <sumit.garg@linaro.org>
Tue, 4 Feb 2025 07:34:18 +0000 (13:04 +0530)
committerArnd Bergmann <arnd@arndb.de>
Fri, 14 Feb 2025 14:17:34 +0000 (15:17 +0100)
commit70b0d6b0a199c5a3ee6c72f5e61681ed6f759612
tree45945cb7bd65be12e4481e9cf283cd424c554804
parentdd0f05b98925111f4530d7dab774398cdb32e9e3
tee: optee: Fix supplicant wait loop

OP-TEE supplicant is a user-space daemon and it's possible for it
be hung or crashed or killed in the middle of processing an OP-TEE
RPC call. It becomes more complicated when there is incorrect shutdown
ordering of the supplicant process vs the OP-TEE client application which
can eventually lead to system hang-up waiting for the closure of the
client application.

Allow the client process waiting in kernel for supplicant response to
be killed rather than indefinitely waiting in an unkillable state. Also,
a normal uninterruptible wait should not have resulted in the hung-task
watchdog getting triggered, but the endless loop would.

This fixes issues observed during system reboot/shutdown when supplicant
got hung for some reason or gets crashed/killed which lead to client
getting hung in an unkillable state. It in turn lead to system being in
hung up state requiring hard power off/on to recover.

Fixes: 4fb0a5eb364d ("tee: add OP-TEE driver")
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Cc: stable@vger.kernel.org
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
drivers/tee/optee/supp.c