]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mm: arm64: document why pte is not advanced in contpte_ptep_set_access_flags()
authorBarry Song <v-songbaohua@oppo.com>
Thu, 5 Sep 2024 08:11:24 +0000 (20:11 +1200)
committerWill Deacon <will@kernel.org>
Fri, 6 Sep 2024 11:28:33 +0000 (12:28 +0100)
commit70565f2be8807e5ea24dfb421197b881a02af5e2
tree64c06e769a98c7376c062e62b12ec882b2089fd1
parenteeb8fdfcf0901578c26ecfb11e814f36bc9a92f5
mm: arm64: document why pte is not advanced in contpte_ptep_set_access_flags()

According to David and Ryan, there isn't a bug here, even though we
don't advance the PTE entry, because __ptep_set_access_flags() only
uses the access flags from the entry.

However, we always check pte_same(pte, entry) using the first entry
in __ptep_set_access_flags(). This means that the checks from 1 to
nr - 1 are not comparing the same PTE indexes (thus, they always
return false), which can be a bit confusing. To clarify the code, let's
add some comments.

Reviewed-by: Ryan Roberts <ryan.roberts@arm.com>
Signed-off-by: Barry Song <v-songbaohua@oppo.com>
Cc: Ard Biesheuvel <ardb@kernel.org>
Cc: John Hubbard <jhubbard@nvidia.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Will Deacon <will@kernel.org>
Reviewed-by: David Hildenbrand <david@redhat.com>
Link: https://lore.kernel.org/r/20240905081124.9576-1-21cnbao@gmail.com
Signed-off-by: Will Deacon <will@kernel.org>
arch/arm64/mm/contpte.c