]> www.infradead.org Git - users/jedix/linux-maple.git/commit
regmap: kunit: fix raw noinc write test wrapping
authorBen Wolsieffer <ben.wolsieffer@hefring.com>
Tue, 6 Feb 2024 15:10:05 +0000 (10:10 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 7 Feb 2024 11:17:11 +0000 (11:17 +0000)
commit7011b51f13b391ee06708bb1f82653a2953f8cfc
tree2f00934aef3f4757bd666b8f232ed99b1f3bb863
parent54be6c6c5ae8e0d93a6c4641cb7528eb0b6ba478
regmap: kunit: fix raw noinc write test wrapping

The raw noinc write test places a known value in the register following
the noinc register to verify that it is not disturbed by the noinc
write. This test ensures this value is distinct by adding 100 to the
second element of the noinc write data.

The regmap registers are 16-bit, while the test value is stored in an
unsigned int. Therefore, adding 100 may cause the register to wrap while
the test value does not, causing the test to fail. This patch fixes this
by changing val_test and val_last from unsigned int to u16.

Signed-off-by: Ben Wolsieffer <ben.wolsieffer@hefring.com>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Closes: https://lore.kernel.org/linux-kernel/745d3a11-15bc-48b6-84c8-c8761c943bed@roeck-us.net/T/
Tested-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20240206151004.1636761-2-ben.wolsieffer@hefring.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap-kunit.c