]> www.infradead.org Git - users/dwmw2/linux.git/commit
perf util: Fix bad memory access in trace info.
authorChris Phlipot <cphlipot0@gmail.com>
Wed, 29 Aug 2018 06:19:54 +0000 (23:19 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Oct 2018 06:55:59 +0000 (08:55 +0200)
commit6f8073072f7b237c139699a2d267b2b619e2a5a7
tree46510102542b8fec7ca1fa6160ec3eb036cd2e98
parent56b4732271c775bff9497d47728b851d82d4520b
perf util: Fix bad memory access in trace info.

[ Upstream commit a72f64261359b7451f8478f2a2bf357b4e6c757f ]

In the write to the output_fd in the error condition of
record_saved_cmdline(), we are writing 8 bytes from a memory location on
the stack that contains a primitive that is only 4 bytes in size.
Change the primitive to 8 bytes in size to match the size of the write
in order to avoid reading unknown memory from the stack.

Signed-off-by: Chris Phlipot <cphlipot0@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20180829061954.18871-1-cphlipot0@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
tools/perf/util/trace-event-info.c