]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: netmem: fix skb_ensure_writable with unreadable skbs
authorMina Almasry <almasrymina@google.com>
Sun, 15 Jun 2025 20:07:33 +0000 (20:07 +0000)
committerJakub Kicinski <kuba@kernel.org>
Tue, 17 Jun 2025 22:48:20 +0000 (15:48 -0700)
commit6f793a1d053775f8324b8dba1e7ed224f8b0166f
treeac70ef0a5f7b5effd7211628dcb1f99963a9d79d
parent60524f1d2bdf222db6dc3f680e0272441f697fe4
net: netmem: fix skb_ensure_writable with unreadable skbs

skb_ensure_writable should succeed when it's trying to write to the
header of the unreadable skbs, so it doesn't need an unconditional
skb_frags_readable check. The preceding pskb_may_pull() call will
succeed if write_len is within the head and fail if we're trying to
write to the unreadable payload, so we don't need an additional check.

Removing this check restores DSCP functionality with unreadable skbs as
it's called from dscp_tg.

Cc: willemb@google.com
Cc: asml.silence@gmail.com
Fixes: 65249feb6b3d ("net: add support for skbs with unreadable frags")
Signed-off-by: Mina Almasry <almasrymina@google.com>
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250615200733.520113-1-almasrymina@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/skbuff.c