]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: dsa: microchip: fix PTP config failure when using multiple ports
authorMartin Whitaker <foss@martin-whitaker.me.uk>
Sat, 17 Aug 2024 09:41:41 +0000 (10:41 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Aug 2024 22:53:56 +0000 (15:53 -0700)
commit6efea5135417ae8194485d1d05ea79a21cf1a11c
tree884c0357982f5e03deeb425fbfcfe084289d35e3
parent8aba27c4a5020abdf60149239198297f88338a8d
net: dsa: microchip: fix PTP config failure when using multiple ports

When performing the port_hwtstamp_set operation, ptp_schedule_worker()
will be called if hardware timestamoing is enabled on any of the ports.
When using multiple ports for PTP, port_hwtstamp_set is executed for
each port. When called for the first time ptp_schedule_worker() returns
0. On subsequent calls it returns 1, indicating the worker is already
scheduled. Currently the ksz driver treats 1 as an error and fails to
complete the port_hwtstamp_set operation, thus leaving the timestamping
configuration for those ports unchanged.

This patch fixes this by ignoring the ptp_schedule_worker() return
value.

Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/7aae307a-35ca-4209-a850-7b2749d40f90@martin-whitaker.me.uk
Fixes: bb01ad30570b0 ("net: dsa: microchip: ptp: manipulating absolute time using ptp hw clock")
Signed-off-by: Martin Whitaker <foss@martin-whitaker.me.uk>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Arun Ramadoss <arun.ramadoss@microchip.com>
Link: https://patch.msgid.link/20240817094141.3332-1-foss@martin-whitaker.me.uk
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/dsa/microchip/ksz_ptp.c