]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ftrace: Test mcount_loc addr before calling ftrace_call_addr()
authorSteven Rostedt <rostedt@goodmis.org>
Tue, 25 Feb 2025 18:20:05 +0000 (13:20 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 25 Feb 2025 18:25:13 +0000 (13:25 -0500)
commit6eeca746fa5f1dd03c6ee05cb03f5eb1ddda1c81
tree5cfed4a03486af2150d19aa5870c01d8eb768eef
parent264143c4e54412095f4b615e65bf736fc3c60af0
ftrace: Test mcount_loc addr before calling ftrace_call_addr()

The addresses in the mcount_loc can be zeroed and then moved by KASLR
making them invalid addresses. ftrace_call_addr() for ARM 64 expects a
valid address to kernel text. If the addr read from the mcount_loc section
is invalid, it must not call ftrace_call_addr(). Move the addr check
before calling ftrace_call_addr() in ftrace_process_locs().

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/20250225182054.290128736@goodmis.org
Fixes: ef378c3b8233 ("scripts/sorttable: Zero out weak functions in mcount_loc table")
Reported-by: Nathan Chancellor <nathan@kernel.org>
Reported-by: "Arnd Bergmann" <arnd@arndb.de>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Closes: https://lore.kernel.org/all/20250225025631.GA271248@ax162/
Closes: https://lore.kernel.org/all/91523154-072b-437b-bbdc-0b70e9783fd0@app.fastmail.com/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/ftrace.c