]> www.infradead.org Git - nvme.git/commit
phy: realtek: usb: Drop unnecessary error check for debugfs_create_dir()
authorJinjie Ruan <ruanjinjie@huawei.com>
Fri, 1 Sep 2023 07:52:31 +0000 (15:52 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 21 Sep 2023 14:14:22 +0000 (16:14 +0200)
commit6ee8a9a772b5abd9a9791123ca7aee2dbf126d5f
tree41b8006f146fdbbb505588d28de18d839279866c
parent426e05ce126e8febc21fae643139a1072d2670ad
phy: realtek: usb: Drop unnecessary error check for debugfs_create_dir()

Both debugfs_create_dir() and debugfs_create_file() return ERR_PTR
and never return NULL.

As Greg suggested, this patch removes the error checking for
debugfs_create_dir in phy-rtk-usb2.c and phy-rtk-usb3.c. This is because
the DebugFS kernel API is developed in a way that the caller can safely
ignore the errors that occur during the creation of DebugFS nodes. The
debugfs APIs have a IS_ERR() judge in start_creating() which can handle it
gracefully. So these checks are unnecessary.

Fixes: 134e6d25f6bd ("phy: realtek: usb: Add driver for the Realtek SoC USB 2.0 PHY")
Fixes: adda6e82a7de ("phy: realtek: usb: Add driver for the Realtek SoC USB 3.0 PHY")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20230901075231.1368947-1-ruanjinjie@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/realtek/phy-rtk-usb2.c
drivers/phy/realtek/phy-rtk-usb3.c