]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/amdgpu: Fix shift type in amdgpu_debugfs_sdma_sched_mask_set()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 8 Jan 2025 09:41:28 +0000 (12:41 +0300)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 9 Jan 2025 21:02:56 +0000 (16:02 -0500)
commit6ec6cd9acbaa844391a1f75a824a3a9d18978fcb
tree35fe69d1d6b1e2b94b5efc9150deed1bcf82fff5
parentf7e672e6f85b92fe3285f7a379121d48b067337d
drm/amdgpu: Fix shift type in amdgpu_debugfs_sdma_sched_mask_set()

The "mask" and "val" variables are type u64.  The problem is that the
BIT() macros are type unsigned long which is just 32 bits on 32bit
systems.

It's unlikely that people will be using this driver on 32bit kernels
and even if they did we only use the lower AMDGPU_MAX_SDMA_INSTANCES (16)
bits.  So this bug does not affect anything in real life.

Still, for correctness sake, u64 bit masks should use BIT_ULL().

Fixes: d2e3961ae371 ("drm/amdgpu: add amdgpu_sdma_sched_mask debugfs")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/d39a9325-87a4-4543-b6ec-1c61fca3a6fc@stanley.mountain
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_sdma.c