]> www.infradead.org Git - users/dwmw2/linux.git/commit
iio: adc: gyroadc: fix uninitialized return code
authorArnd Bergmann <arnd@arndb.de>
Thu, 18 Jul 2019 13:57:49 +0000 (15:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 16 Aug 2019 08:10:49 +0000 (10:10 +0200)
commit6eafa28bf8c6d52fa62d5d251c70558d3cb40b79
tree8c9fcca9d3b090edc510416944a3b9013984c904
parentab7278aafbbef72f43eb5775fe13a855eff1df38
iio: adc: gyroadc: fix uninitialized return code

commit 90c6260c1905a68fb596844087f2223bd4657fee upstream.

gcc-9 complains about a blatant uninitialized variable use that
all earlier compiler versions missed:

drivers/iio/adc/rcar-gyroadc.c:510:5: warning: 'ret' may be used uninitialized in this function [-Wmaybe-uninitialized]

Return -EINVAL instead here and a few lines above it where
we accidentally return 0 on failure.

Cc: stable@vger.kernel.org
Fixes: 059c53b32329 ("iio: adc: Add Renesas GyroADC driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/iio/adc/rcar-gyroadc.c