]> www.infradead.org Git - users/jedix/linux-maple.git/commit
posix-clock: posix-clock: Fix unbalanced locking in pc_clock_settime()
authorJinjie Ruan <ruanjinjie@huawei.com>
Fri, 18 Oct 2024 10:07:48 +0000 (18:07 +0800)
committerPaolo Abeni <pabeni@redhat.com>
Wed, 23 Oct 2024 14:05:01 +0000 (16:05 +0200)
commit6e62807c7fbb3c758d233018caf94dfea9c65dbd
tree956284902f28562231b31e78522a1490597c43cf
parent10ce0db787004875f4dba068ea952207d1d8abeb
posix-clock: posix-clock: Fix unbalanced locking in pc_clock_settime()

If get_clock_desc() succeeds, it calls fget() for the clockid's fd,
and get the clk->rwsem read lock, so the error path should release
the lock to make the lock balance and fput the clockid's fd to make
the refcount balance and release the fd related resource.

However the below commit left the error path locked behind resulting in
unbalanced locking. Check timespec64_valid_strict() before
get_clock_desc() to fix it, because the "ts" is not changed
after that.

Fixes: d8794ac20a29 ("posix-clock: Fix missing timespec64 check in pc_clock_settime()")
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Acked-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
[pabeni@redhat.com: fixed commit message typo]
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
kernel/time/posix-clock.c