]> www.infradead.org Git - users/hch/misc.git/commit
xfs: fix data fork format filtering during inode repair
authorDarrick J. Wong <djwong@kernel.org>
Mon, 3 Feb 2025 00:50:14 +0000 (16:50 -0800)
committerCarlos Maiolino <cem@kernel.org>
Fri, 14 Feb 2025 08:40:24 +0000 (09:40 +0100)
commit6e33017c3276e3af7f79f61f3b3648e4a4c03d34
tree29cef2687d62592a38983f1ab439f5fd82c00740
parent66314e9a57a050f95cb0ebac904f5ab047a8926e
xfs: fix data fork format filtering during inode repair

Coverity noticed that xrep_dinode_bad_metabt_fork never runs because
XFS_DINODE_FMT_META_BTREE is always filtered out in the mode selection
switch of xrep_dinode_check_dfork.

Metadata btrees are allowed only in the data forks of regular files, so
add this case explicitly.  I guess this got fubard during a refactoring
prior to 6.13 and I didn't notice until now. :/

Coverity-id: 1617714
Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/scrub/inode_repair.c