]> www.infradead.org Git - nvme.git/commit
SUNRPC: Fix backchannel reply, again
authorChuck Lever <chuck.lever@oracle.com>
Wed, 19 Jun 2024 13:51:08 +0000 (09:51 -0400)
committerTrond Myklebust <trond.myklebust@hammerspace.com>
Fri, 21 Jun 2024 21:26:02 +0000 (17:26 -0400)
commit6ddc9deacc1312762c2edd9de00ce76b00f69f7c
tree2913169a2b3a2d4598045f5004fd75ce4afbab6d
parent6ba59ff4227927d3a8530fc2973b80e94b54d58f
SUNRPC: Fix backchannel reply, again

I still see "RPC: Could not send backchannel reply error: -110"
quite often, along with slow-running tests. Debugging shows that the
backchannel is still stumbling when it has to queue a callback reply
on a busy transport.

Note that every one of these timeouts causes a connection loss by
virtue of the xprt_conditional_disconnect() call in that arm of
call_cb_transmit_status().

I found that setting to_maxval is necessary to get the RPC timeout
logic to behave whenever to_exponential is not set.

Fixes: 57331a59ac0d ("NFSv4.1: Use the nfs_client's rpc timeouts for backchannel")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
net/sunrpc/svc.c