]> www.infradead.org Git - users/dwmw2/linux.git/commit
drm/xe/guc: Fix dereference before NULL check
authorEverest K.C. <everestkc@everestkc.com.np>
Wed, 23 Oct 2024 23:33:55 +0000 (17:33 -0600)
committerThomas Hellström <thomas.hellstrom@linux.intel.com>
Thu, 14 Nov 2024 13:55:01 +0000 (14:55 +0100)
commit6d9f9115c091c88cacf78734d8ea34c8609e8680
tree79fcf01f7e41d6bfeb36706985fa3119af494d15
parent56b70bf9ec460ad7d7d94dfb7a54a8829741e16e
drm/xe/guc: Fix dereference before NULL check

The pointer list->list is dereferenced before the NULL check.
Fix this by moving the NULL check outside the for loop, so that
the check is performed before the dereferencing.
The list->list pointer cannot be NULL so this has no effect on runtime.
It's just a correctness issue.

This issue was reported by Coverity Scan.
https://scan7.scan.coverity.com/#/project-view/51525/11354?selectedIssue=1600335

Fixes: 0f1fdf559225 ("drm/xe/guc: Save manual engine capture into capture list")
Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: John Harrison <John.C.Harrison@Intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241023233356.5479-1-everestkc@everestkc.com.np
(cherry picked from commit 2aff81e039de5b0b7ef6bdcb2c320f121f69e2b4)
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
drivers/gpu/drm/xe/xe_guc_capture.c