]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/radeon: forbid mapping of userptr bo through radeon device file
authorJérôme Glisse <jglisse@redhat.com>
Tue, 19 Apr 2016 13:07:50 +0000 (09:07 -0400)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:21:50 +0000 (17:21 -0500)
commit6d83cc7613d0ad31b506ab503d1c2c87274aed0e
tree04dc7d372b284d57be5a4135332d484ca11098dc
parent73f20d9324facbb11d030279f37a96fc7b21152d
drm/radeon: forbid mapping of userptr bo through radeon device file

Orabug: 25227133

[ Upstream commit b5dcec693f87cb8475f2291c0075b2422addd3d6 ]

Allowing userptr bo which are basicly a list of page from some vma
(so either anonymous page or file backed page) would lead to serious
corruption of kernel structures and counters (because we overwrite
the page->mapping field when mapping buffer).

This will already block if the buffer was populated before anyone does
try to mmap it because then TTM_PAGE_FLAG_SG would be set in in the
ttm_tt flags. But that flag is check before ttm_tt_populate in the ttm
vm fault handler.

So to be safe just add a check to verify_access() callback.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Jérôme Glisse <jglisse@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 2719d3c05d4c93054e7c5838cc5b1906f72b465e)

Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/gpu/drm/radeon/radeon_ttm.c