]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: nexthop: Initialize all fields in dumped nexthops
authorPetr Machata <petrm@nvidia.com>
Tue, 23 Jul 2024 16:04:16 +0000 (18:04 +0200)
committerDavid S. Miller <davem@davemloft.net>
Wed, 24 Jul 2024 14:13:43 +0000 (15:13 +0100)
commit6d745cd0e9720282cd291d36b9db528aea18add2
tree2ec6ea8e2d02084a4bf81655b6e586e9d5fcf9a1
parente9dbebae2e3c338122716914fe105458f41e3a4a
net: nexthop: Initialize all fields in dumped nexthops

struct nexthop_grp contains two reserved fields that are not initialized by
nla_put_nh_group(), and carry garbage. This can be observed e.g. with
strace (edited for clarity):

    # ip nexthop add id 1 dev lo
    # ip nexthop add id 101 group 1
    # strace -e recvmsg ip nexthop get id 101
    ...
    recvmsg(... [{nla_len=12, nla_type=NHA_GROUP},
                 [{id=1, weight=0, resvd1=0x69, resvd2=0x67}]] ...) = 52

The fields are reserved and therefore not currently used. But as they are, they
leak kernel memory, and the fact they are not just zero complicates repurposing
of the fields for new ends. Initialize the full structure.

Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/nexthop.c