]> www.infradead.org Git - users/jedix/linux-maple.git/commit
tracing: Fix ifdef of snapshots to not prevent last_boot_info file
authorSteven Rostedt <rostedt@goodmis.org>
Fri, 19 Jul 2024 14:13:12 +0000 (10:13 -0400)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 14 Aug 2024 21:01:03 +0000 (17:01 -0400)
commit6d02eefecc5e3887eea08f3df5e0f2af6eb35447
tree14cd5e9f4730b037ec9b246923f2b7e17bda2a0e
parentee057c8c194b9283f4137b253b70e292693a39f0
tracing: Fix ifdef of snapshots to not prevent last_boot_info file

The mapping of the ring buffer to memory allocated at boot up will also
expose a "last_boot_info" to help tooling to read the raw data from the
last boot. As instances that have their ring buffer mapped to fixed
memory cannot perform snapshots, they can either have the "snapshot" file
or the "last_boot_info" file, but not both.

The code that added the "last_boot_info" file failed to notice that the
"snapshot" creation was inside a "#ifdef CONFIG_TRACER_SNAPSHOT" and
incorrectly placed the creation of the "last_boot_info" file within the
ifdef block. Not only does it cause a warning when CONFIG_TRACER_SNAPSHOT
is not enabled, it also incorrectly prevents the file from appearing.

Link: https://lore.kernel.org/all/20240719102640.718554-1-arnd@kernel.org/
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Reported-by: Arnd Bergmann <arnd@kernel.org>
Link: https://lore.kernel.org/20240719101312.3d4ac707@rorschach.local.home
Fixes: 7a1d1e4b9639 ("tracing/ring-buffer: Add last_boot_info file to boot instance")
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace.c