]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ufs: ufs_sb_private_info: remove unused s_{2,3}apb fields
authorAgathe Porte <agathe.porte@canonical.com>
Tue, 12 Nov 2024 12:18:25 +0000 (13:18 +0100)
committerAl Viro <viro@zeniv.linux.org.uk>
Wed, 13 Nov 2024 00:02:12 +0000 (19:02 -0500)
commit6cfe56fbad32c8c5b50e82d9109413566d691569
tree180f0e7d91f101c759405b5e43417cc0915176bb
parentb57c010e70ff11cce7f6b702d2e3bba1d893580b
ufs: ufs_sb_private_info: remove unused s_{2,3}apb fields

These two fields are populated and stored as a "frequently used value"
in ufs_fill_super, but are not used afterwards in the driver.

Moreover, one of the shifts triggers UBSAN: shift-out-of-bounds when
apbshift is 12 because 12 * 3 = 36 and 1 << 36 does not fit in the 32
bit integer used to store the value.

Closes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2087853
Signed-off-by: Agathe Porte <agathe.porte@canonical.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
fs/ufs/super.c
fs/ufs/ufs_fs.h