]> www.infradead.org Git - users/dwmw2/linux.git/commit
xfrm: Don't disable preemption while looking up cache state.
authorSebastian Sewior <bigeasy@linutronix.de>
Thu, 23 Jan 2025 16:20:45 +0000 (17:20 +0100)
committerSteffen Klassert <steffen.klassert@secunet.com>
Fri, 24 Jan 2025 06:46:11 +0000 (07:46 +0100)
commit6c9b7db96db62ee9ad8d359d90ff468d462518c4
tree1fa40ade4340bac8e85b54ee5b63166229e91598
parent1620c88887b16940e00dbe57dd38c74eda9bad9e
xfrm: Don't disable preemption while looking up cache state.

For the state cache lookup xfrm_input_state_lookup() first disables
preemption, to remain on the CPU and then retrieves a per-CPU pointer.
Within the preempt-disable section it also acquires
netns_xfrm::xfrm_state_lock, a spinlock_t. This lock must not be
acquired with explicit disabled preemption (such as by get_cpu())
because this lock becomes a sleeping lock on PREEMPT_RT.

To remain on the same CPU is just an optimisation for the CPU local
lookup. The actual modification of the per-CPU variable happens with
netns_xfrm::xfrm_state_lock acquired.

Remove get_cpu() and use the state_cache_input on the current CPU.

Reported-by: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Closes: https://lore.kernel.org/all/CAADnVQKkCLaj=roayH=Mjiiqz_svdf1tsC3OE4EC0E=mAD+L1A@mail.gmail.com/
Fixes: 81a331a0e72dd ("xfrm: Add an inbound percpu state cache.")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_state.c