]> www.infradead.org Git - users/jedix/linux-maple.git/commit
asus-laptop: Fix an uninitialized variable
authorDenis Arefev <arefev@swemel.ru>
Thu, 3 Apr 2025 12:26:01 +0000 (15:26 +0300)
committerIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Fri, 11 Apr 2025 09:52:57 +0000 (12:52 +0300)
commit6c683c6887e4addcd6bd1ddce08cafccb0a21e32
treedbe130410066e2e8ef378efba49b9fe921224c9b
parentd8455a63f731b4f585acc4d49fd7ad78db63b3d0
asus-laptop: Fix an uninitialized variable

The value returned by acpi_evaluate_integer() is not checked,
but the result is not always successful, so it is necessary to
add a check of the returned value.

If the result remains negative during three iterations of the loop,
then the uninitialized variable 'val' will be used in the clamp_val()
macro, so it must be initialized with the current value of the 'curr'
variable.

In this case, the algorithm should be less noisy.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: b23910c2194e ("asus-laptop: Pegatron Lucid accelerometer")
Cc: stable@vger.kernel.org
Signed-off-by: Denis Arefev <arefev@swemel.ru>
Link: https://lore.kernel.org/r/20250403122603.18172-1-arefev@swemel.ru
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
drivers/platform/x86/asus-laptop.c