]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: ethernet: xgbe: re-add aneg to supported features in PHY quirks
authorHeiner Kallweit <hkallweit1@gmail.com>
Sun, 12 Jan 2025 21:59:59 +0000 (22:59 +0100)
committerJakub Kicinski <kuba@kernel.org>
Wed, 15 Jan 2025 21:26:59 +0000 (13:26 -0800)
commit6be7aca91009865d8c2b73589270224a6b6e67ab
treea985cfe801519ce5f87a259d41b5e147730bfcb8
parentd6e3316a1680305da291a5b5deaf424559aaf06c
net: ethernet: xgbe: re-add aneg to supported features in PHY quirks

In 4.19, before the switch to linkmode bitmaps, PHY_GBIT_FEATURES
included feature bits for aneg and TP/MII ports.

 SUPPORTED_TP | \
 SUPPORTED_MII)

 SUPPORTED_10baseT_Full)

 SUPPORTED_100baseT_Full)

 SUPPORTED_1000baseT_Full)

 PHY_100BT_FEATURES | \
 PHY_DEFAULT_FEATURES)

 PHY_1000BT_FEATURES)

Referenced commit expanded PHY_GBIT_FEATURES, silently removing
PHY_DEFAULT_FEATURES. The removed part can be re-added by using
the new PHY_GBIT_FEATURES definition.
Not clear to me is why nobody seems to have noticed this issue.

I stumbled across this when checking what it takes to make
phy_10_100_features_array et al private to phylib.

Fixes: d0939c26c53a ("net: ethernet: xgbe: expand PHY_GBIT_FEAUTRES")
Cc: stable@vger.kernel.org
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/46521973-7738-4157-9f5e-0bb6f694acba@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c