]> www.infradead.org Git - users/willy/pagecache.git/commit
splice: do not checksum AF_UNIX sockets
authorFrederik Deweerdt <deweerdt.lkml@gmail.com>
Tue, 10 Dec 2024 05:06:48 +0000 (21:06 -0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 12 Dec 2024 04:22:41 +0000 (20:22 -0800)
commit6bd8614fc2d076fc21b7488c9f279853960964e2
treef126577c3b9200fd3e0af219229e0828ffaa2a16
parent3b58b53a26598209a7ad8259a5114ce71f7c3d64
splice: do not checksum AF_UNIX sockets

When `skb_splice_from_iter` was introduced, it inadvertently added
checksumming for AF_UNIX sockets. This resulted in significant
slowdowns, for example when using sendfile over unix sockets.

Using the test code in [1] in my test setup (2G single core qemu),
the client receives a 1000M file in:
- without the patch: 1482ms (+/- 36ms)
- with the patch: 652.5ms (+/- 22.9ms)

This commit addresses the issue by marking checksumming as unnecessary in
`unix_stream_sendmsg`

Cc: stable@vger.kernel.org
Signed-off-by: Frederik Deweerdt <deweerdt.lkml@gmail.com>
Fixes: 2e910b95329c ("net: Add a function to splice pages into an skbuff for MSG_SPLICE_PAGES")
Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Link: https://patch.msgid.link/Z1fMaHkRf8cfubuE@xiberoa
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/unix/af_unix.c