]> www.infradead.org Git - users/willy/xarray.git/commit
ice: do not clutter debug logs with unused data
authorBruce Allan <bruce.w.allan@intel.com>
Tue, 6 Aug 2024 20:46:23 +0000 (13:46 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Mon, 26 Aug 2024 16:39:34 +0000 (09:39 -0700)
commit6bd7cb522b1c06f826b74a40c5a0f23b1e4d00ae
treef365379907433a378a21b97b4c007f4e0277f597
parentcaf4daae871c20a3da1a822d8713c858c8a85d5c
ice: do not clutter debug logs with unused data

Currently, debug logs are unnecessarily cluttered with the contents of
command data buffers even if the receiver of that command (i.e. FW or MBX)
are not told to read the buffer.  Change to only log command data buffers
when the RD flag (indicates receiver needs to read the buffer) is set.
Continue to log response data buffer when the returned datalen is non-zero.

Also, rename a local variable to reflect what is in the hardware
specification and how it is used elsewhere in the code, use local variables
instead of duplicating endian conversions unnecessarily and remove an
unnecessary assignment.

Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_adminq_cmd.h
drivers/net/ethernet/intel/ice/ice_controlq.c