]> www.infradead.org Git - users/jedix/linux-maple.git/commit
RISC-V: KVM: Fix sbiret init before forwarding to userspace
authorAndrew Jones <ajones@ventanamicro.com>
Wed, 7 Aug 2024 15:49:44 +0000 (17:49 +0200)
committerAnup Patel <anup@brainfault.org>
Mon, 19 Aug 2024 03:02:10 +0000 (08:32 +0530)
commit6b7b282e6baea06ba65b55ae7d38326ceb79cebf
tree22df6a241331dc30a3458107d51ae7a6669cd785
parent47ac09b91befbb6a235ab620c32af719f8208399
RISC-V: KVM: Fix sbiret init before forwarding to userspace

When forwarding SBI calls to userspace ensure sbiret.error is
initialized to SBI_ERR_NOT_SUPPORTED first, in case userspace
neglects to set it to anything. If userspace neglects it then we
can't be sure it did anything else either, so we just report it
didn't do or try anything. Just init sbiret.value to zero, which is
the preferred value to return when nothing special is specified.

KVM was already initializing both sbiret.error and sbiret.value, but
the values used appear to come from a copy+paste of the __sbi_ecall()
implementation, i.e. a0 and a1, which don't apply prior to the call
being executed, nor at all when forwarding to userspace.

Fixes: dea8ee31a039 ("RISC-V: KVM: Add SBI v0.1 support")
Signed-off-by: Andrew Jones <ajones@ventanamicro.com>
Link: https://lore.kernel.org/r/20240807154943.150540-2-ajones@ventanamicro.com
Signed-off-by: Anup Patel <anup@brainfault.org>
arch/riscv/kvm/vcpu_sbi.c