]> www.infradead.org Git - users/jedix/linux-maple.git/commit
hwmon: (pmbus) Initialise page count in pmbus_identify()
authorTitus Rwantare <titusr@google.com>
Thu, 27 Feb 2025 22:24:55 +0000 (22:24 +0000)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 2 Mar 2025 16:27:22 +0000 (08:27 -0800)
commit6b6e2e8fd0de3fa7c6f4f8fe6841b01770b2e7bc
treece287028c05afeddb9fda51562a2d6d5390cc19a
parent5797c04400ee117bfe459ff1e468d0ea38054ab4
hwmon: (pmbus) Initialise page count in pmbus_identify()

The `pmbus_identify()` function fails to correctly determine the number
of supported pages on PMBus devices. This occurs because `info->pages`
is implicitly zero-initialised, and `pmbus_set_page()` does not perform
writes to the page register if `info->pages` is not yet initialised.
Without this patch, `info->pages` is always set to the maximum after
scanning.

This patch initialises `info->pages` to `PMBUS_PAGES` before the probing
loop, enabling `pmbus_set_page()` writes to make it out onto the bus
correctly identifying the number of pages. `PMBUS_PAGES` seemed like a
reasonable non-zero number because that's the current result of the
identification process.

Testing was done with a PMBus device in QEMU.

Signed-off-by: Titus Rwantare <titusr@google.com>
Fixes: 442aba78728e7 ("hwmon: PMBus device driver")
Link: https://lore.kernel.org/r/20250227222455.2583468-1-titusr@google.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pmbus/pmbus.c