]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net/tcp: Add missing lockdep annotations for TCP-AO hlist traversals
authorDmitry Safonov <0x7f454c46@gmail.com>
Wed, 30 Oct 2024 04:22:33 +0000 (04:22 +0000)
committerJakub Kicinski <kuba@kernel.org>
Sun, 3 Nov 2024 20:10:11 +0000 (12:10 -0800)
commit6b2d11e2d8fc130df4708be0b6b53fd3e6b54cf6
treeb6d8000fc99731fe31738ede8c35a03f0e308c4a
parent6578a7499af125fcea9882635dffe963b7014ff0
net/tcp: Add missing lockdep annotations for TCP-AO hlist traversals

Under CONFIG_PROVE_RCU_LIST + CONFIG_RCU_EXPERT
hlist_for_each_entry_rcu() provides very helpful splats, which help
to find possible issues. I missed CONFIG_RCU_EXPERT=y in my testing
config the same as described in
a3e4bf7f9675 ("configs/debug: make sure PROVE_RCU_LIST=y takes effect").

The fix itself is trivial: add the very same lockdep annotations
as were used to dereference ao_info from the socket.

Reported-by: Jakub Kicinski <kuba@kernel.org>
Closes: https://lore.kernel.org/netdev/20241028152645.35a8be66@kernel.org/
Signed-off-by: Dmitry Safonov <0x7f454c46@gmail.com>
Link: https://patch.msgid.link/20241030-tcp-ao-hlist-lockdep-annotate-v1-1-bf641a64d7c6@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/tcp_ao.h
net/ipv4/tcp_ao.c
net/ipv4/tcp_ipv4.c
net/ipv6/tcp_ipv6.c