]> www.infradead.org Git - users/hch/block.git/commit
nvme-tcp: use sendpages_ok() instead of sendpage_ok()
authorOfir Gal <ofir.gal@volumez.com>
Thu, 18 Jul 2024 08:45:13 +0000 (11:45 +0300)
committerJens Axboe <axboe@kernel.dk>
Sun, 28 Jul 2024 22:47:52 +0000 (16:47 -0600)
commit6af7331a70b4888df43ec1d7e1803ae2c43b6981
tree8e8eb1b6f91909797cd5fd9755645fe10c46a415
parent23a55f4492fcf868d068da31a2cd30c15f46207d
nvme-tcp: use sendpages_ok() instead of sendpage_ok()

Currently nvme_tcp_try_send_data() use sendpage_ok() in order to disable
MSG_SPLICE_PAGES, it check the first page of the iterator, the iterator
may represent contiguous pages.

MSG_SPLICE_PAGES enables skb_splice_from_iter() which checks all the
pages it sends with sendpage_ok().

When nvme_tcp_try_send_data() sends an iterator that the first page is
sendable, but one of the other pages isn't skb_splice_from_iter() warns
and aborts the data transfer.

Using the new helper sendpages_ok() in order to disable MSG_SPLICE_PAGES
solves the issue.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Ofir Gal <ofir.gal@volumez.com>
Link: https://lore.kernel.org/r/20240718084515.3833733-3-ofir.gal@volumez.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/nvme/host/tcp.c